gnoi/os: limit OS image size in ReceiveOS to prevent unbounded memory allocation #404
Open
kazisabu wants to merge 1 commit into
Open
gnoi/os: limit OS image size in ReceiveOS to prevent unbounded memory allocation #404kazisabu wants to merge 1 commit into
kazisabu wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
For the record, this issue has been validated as a security vulnerability by the Google VRP team. I am currently in the process of requesting a CVE ID for this issue to ensure it is documented for the community. If any maintainers are available to review the fix, I would appreciate the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a maximum OS image size limit to ReceiveOS to prevent unbounded
memory allocation (DoS).
Changes made in gnoi/os/server.go:
Added const maxOSImageSize = 1 << 30 (1GB) constant after
receiveChunkSizeAck variable declaration (lines 29-31).
Added a size check after bb.Write() in the TransferContent case
of ReceiveOS that returns an error when the buffer exceeds
maxOSImageSize (lines 186-188).
Without this fix, an authenticated client can stream unlimited chunks
to the Install RPC, causing the server to allocate memory until
OOM-killed. The existing installToken semaphore limits concurrency
to 1 but does not prevent a single session from exhausting memory.